-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass useEmberModule option to plugins #682
Conversation
@@ -76,7 +76,7 @@ | |||
"ember-maybe-import-regenerator": "^0.1.6", | |||
"ember-qunit": "^4.6.0", | |||
"ember-resolver": "^8.0.0", | |||
"ember-source": "~3.25.0", | |||
"ember-source": "~3.27.0-alpha.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've upgraded here and also added the ember
key below just so I can test locally. I'll remove these before merging
I was chatting with @pzuraq about this yesterday, I think we probably want to update the babel-plugin-htmlbars-inline-precompile to just leverage the "real modules" when we are operating on Ember 3.27+. I believe that @pzuraq is working on a PR that finishes out emberjs/ember.js#16529. |
@rwjblue thanks! so I can close this PR? |
Hmm, no I don't think so. I think we'll likely still need some change here, but instead of having that babel plugin inject the |
Basically, this option: We want to ensure that we pass |
Yep! Thank you again! |
I'm just working my way through various things here and pushing up what I have so far to help get myself unblocked.
It appears we require a new release of ember-cli-babel with Update babel plugins and pin to @babel/[email protected] emberjs/ember-cli-babel#385 (as it has an upgrade of
babel-plugin-ember-modules-api-polyfill
) because it looks like the imports mismatch in tests (imports_ember2
but uses_ember
) instead. We require an upgrade ofColocated components don't appear to be transformed from using the global Ember