Ensure AST plugins have the same ordering as < [email protected]. #665
Conversation
We have to reverse these for reasons that are a bit bonkers. The initial version of this system used `registeredPlugin` from `ember-template-compiler.js` to set up these plugins (because Ember ~ 1.13 only had `registerPlugin`, and there was no way to pass plugins directly to the call to `compile`/`precompile`). Calling `registerPlugin` unfortunately **inverted** the order of plugins (it essentially did `PLUGINS = [plugin, ...PLUGINS]`). Sooooooo...... we are forced to maintain that **absolutely bonkers** ordering.
|
FWIW, this is also exactly why Embroider has to do: |
|
Is there a list somewhere we can add this to so we make it rational in a breaking change for Ember 4.0? Or are stuck with this forever? |
|
@lukemelia - Hmm. I would really like to find a way to do it, but I don't know of a reasonable path forward. We could easily guard this reversing code (and the code in Embroider that I linked) to avoid reversing when running against Ember >= 4, but then any addon that wants to support both Ember < 4 and 4 will have no way to actually guarantee the ordering. |
|
Ironically, with Ember 4 the reason for reversing will actually be gone (since the |
|
@lukemelia - Mind making an issue to track the discussion / brain storming? Seems fine to do here, emberjs/rfcs, emberjs/ember.js, or Embroider repos... |
|
@rwjblue created emberjs/rfcs#725 |
|
Thank you! |
We have to reverse these for reasons that are a bit bonkers. The initial version of this system used
registeredPluginfromember-template-compiler.jsto set up these plugins (because Ember ~ 1.13 only hadregisterPlugin, and there was no way to pass plugins directly to the call tocompile/precompile). CallingregisterPluginunfortunately inverted the order of plugins (it essentially didPLUGINS = [plugin, ...PLUGINS]).Sooooooo...... we are forced to maintain that absolutely bonkers ordering.
This should address #664, but I'd like to leave it open so @simonihmig can confirm.