Ember Ember 3.27+ can determine global for template compilation #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node 12+ has access to `globalThis` (including within a VM context), but older versions do not. Due to the detection done in https://git.io/Jtb7s, when we can't find `globalThis` (and don't define `global` global) evaluating `ember-template-compiler.js` throws an error "unable to locate global object". This ensures that either `globalThis` or `global` are defined.
This would have caught the error reported in emberjs/ember.js#19431, we should run with the lowest supported Node version.
delete-merged-branch
bot
deleted the
ensure-global-can-be-found-for-canary
branch
This was referenced Mar 14, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure Ember 3.27+ can determine global for template compilation.
Node 12+ has access to
globalThis(including within a VM context), but older versions do not.Due to the detection done in https://git.io/Jtb7s, when we can't find
globalThis(and don't defineglobalglobal) evaluatingember-template-compiler.jsthrows an error "unable to locate global object".This ensures that either
globalThisorglobalare defined.Fixes emberjs/ember.js#19431