Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type definition for test helper import #481

Merged
merged 5 commits into from
Apr 8, 2020
Merged

Add type definition for test helper import #481

merged 5 commits into from
Apr 8, 2020

Conversation

chriskrycho
Copy link
Contributor

@rwjblue rwjblue merged commit 517502e into ember-cli:master Apr 8, 2020
@richard-viney
Copy link

In testing [email protected] it doesn't appear to actually include the new type definitions in the package, i.e. node_modules/ember-cli-htmlbars/index.d.ts doesn't exist after installing with yarn.

Inspecting the contents of https://registry.npmjs.org/ember-cli-htmlbars/-/ember-cli-htmlbars-4.3.0.tgz also shows no type definitions are present.

@chriskrycho chriskrycho deleted the types branch April 9, 2020 12:56
@chriskrycho
Copy link
Contributor Author

Doh! That would be because the files key in package.json only specifies lib, I believe. Should be an easy and quick fix; I’ll have a PR up in an hour or so.

@rwjblue
Copy link
Member

rwjblue commented Apr 9, 2020

Fixed in #494

@chriskrycho
Copy link
Contributor Author

SNIPED!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Types for: import { hbs } from 'ember-cli-htmlbars'
3 participants