Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken ember-source version check in nested addons #687

Closed
ef4 opened this issue Mar 28, 2021 · 0 comments · Fixed by #741
Closed

Broken ember-source version check in nested addons #687

ef4 opened this issue Mar 28, 2021 · 0 comments · Fixed by #741

Comments

@ef4
Copy link
Contributor

ef4 commented Mar 28, 2021

I think we have the same kind of bug here as we did in ember-cli-babel.

It needs to check the ember-source version of the top-level project, not the parent package.
simonihmig added a commit to simonihmig/ember-cli-htmlbars that referenced this issue Dec 9, 2021
@simonihmig
Fix incorrect ember-source version check
b61b91b 
Found this bug in a monorepo setup with multiple apps, where one app was using an older version (3.26, so needed the modules API polyfill) while the others were on 3.28. With most dependencies being hoisted in the central `/node_modules`, for any addon that depends on ember-cli-htmlbars it would find the wrong ember-source package, namely `/node_modules/ember-source` instead of `apps/foo-app/node_modules/ember-source` (the correct 3.26 version).

Fixes ember-cli#687
@simonihmig simonihmig mentioned this issue Dec 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix incorrect ember-source version check simonihmig/ember-cli-htmlbars
1 participant
@ef4