Merge pull request #547 from ember-cli/add-more-logging-for-ast-plugins

ember-cli · May 7, 2020 · d4bf542 · d4bf542
2 parents 1f44a40 + 116126b
commit d4bf542
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 2 deletions.
diff --git a/lib/ember-addon-main.js b/lib/ember-addon-main.js
@@ -83,6 +83,7 @@ module.exports = {
           inputTree = debugTree(new ColocatedTemplateProcessor(inputTree), '02-colocated-output');
         }
 
+        this._addon.logger.debug(`setup *.hbs compiler with ${htmlbarsOptions.pluginNames}`);
         const TemplateCompiler = require('./template-compiler-plugin');
         return debugTree(new TemplateCompiler(inputTree, htmlbarsOptions), '03-output');
       },
@@ -152,7 +153,9 @@ module.exports = {
       let templateCompilerPath = this.templateCompilerPath();
 
       if (pluginInfo.canParallelize) {
-        this.logger.debug('using parallel API with for babel inline precompilation plugin');
+        this.logger.debug(
+          `using babel inline precompilation plugin (parallelized) with ${pluginInfo.pluginNames}`
+        );
 
         let htmlbarsInlinePrecompilePlugin = utils.buildParalleizedBabelPlugin(
           pluginInfo,
@@ -162,7 +165,9 @@ module.exports = {
 
         babelPlugins.push(htmlbarsInlinePrecompilePlugin);
       } else {
-        this.logger.debug('NOT using parallel API with for babel inline precompilation plugin');
+        this.logger.debug(
+          `using babel inline precompilation plugin (NON-parallelized) with ${pluginInfo.pluginNames}`
+        );
         this.logger.debug('Prevented by these plugins: ' + pluginInfo.unparallelizableWrappers);
 
         let htmlBarsPlugin = utils.setup(pluginInfo, {

diff --git a/lib/utils.js b/lib/utils.js
@@ -86,6 +86,7 @@ function buildOptions(projectConfig, templateCompilerPath, pluginInfo) {
     templateCompiler: require(templateCompilerPath),
     templateCompilerPath: templateCompilerPath,
 
+    pluginNames: pluginInfo.pluginNames,
     plugins: {
       ast: pluginInfo.plugins,
     },
@@ -221,6 +222,7 @@ function makeCacheKey(templateCompilerPath, pluginInfo, extra) {
 function setupPlugins(wrappers) {
   let plugins = [];
   let cacheKeys = [];
+  let pluginNames = [];
   let parallelConfigs = [];
   let unparallelizableWrappers = [];
   let dependencyInvalidation = false;
@@ -234,6 +236,8 @@ function setupPlugins(wrappers) {
       wrapper = plugin[wrapper.buildUsing](wrapper.params);
     }
 
+    pluginNames.push(wrapper.name ? wrapper.name : 'unknown plugin');
+
     if (wrapper.parallelBabel) {
       parallelConfigs.push(wrapper.parallelBabel);
     } else {
@@ -268,6 +272,7 @@ function setupPlugins(wrappers) {
 
   return {
     plugins,
+    pluginNames,
     cacheKeys,
     parallelConfigs,
     canParallelize,

diff --git a/node-tests/utils_test.js b/node-tests/utils_test.js
@@ -42,6 +42,7 @@ describe('utils', function () {
 
       assert.deepStrictEqual(actual, {
         plugins: [],
+        pluginNames: [],
         cacheKeys: [],
         parallelConfigs: [],
         canParallelize: true,
@@ -53,13 +54,15 @@ describe('utils', function () {
     it('canParallelize for 1+ plugins with "parallelBabel" property', function () {
       let pluginWrappers = [
         {
+          name: 'first',
           plugin() {},
           cacheKey() {
             return this.parallelBabel;
           },
           parallelBabel: 'something',
         },
         {
+          name: 'second',
           plugin() {},
           cacheKey() {
             return this.parallelBabel;
@@ -72,6 +75,7 @@ describe('utils', function () {
 
       assert.deepStrictEqual(actual, {
         plugins: pluginWrappers.map((w) => w.plugin),
+        pluginNames: ['first', 'second'],
         cacheKeys: ['something', 'something else'],
         parallelConfigs: ['something', 'something else'],
         canParallelize: true,
@@ -103,6 +107,7 @@ describe('utils', function () {
 
       assert.deepStrictEqual(actual, {
         plugins: pluginWrappers.map((w) => w.plugin),
+        pluginNames: ['first', 'second'],
         cacheKeys: ['something', 'something else'],
         parallelConfigs: ['something'],
         canParallelize: false,