This repository has been archived by the owner on Dec 8, 2024. It is now read-only.
[BUGFIX] Use a unique identifier for each reference #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we reuse the same identifier for each reference to an imported value. Apparently this is not the way the scope system is meant to work, and instead we should be creating a new id node for each reference.
rwjblue
approved these changes
Mar 17, 2021
This was referenced Mar 18, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we reuse the same identifier for each reference to an imported
value. Apparently this is not the way the scope system is meant to work,
and instead we should be creating a new id node for each reference.