Skip to content
This repository has been archived by the owner on Dec 8, 2024. It is now read-only.

Default ensureModuleApiPolyfill to true #347

Merged

Conversation

pzuraq
Copy link

@pzuraq pzuraq commented Feb 24, 2021

When we released the refactor to transform to module names instead of
the API polyfill, sometimes those modules would transform correctly,
and sometimes they wouldn't. There appears to be a race condition
between babel-plugin-ember-modules-api-polyfill, this plugin, and the
AMD module transform.

This PR updates the default for ensureModuleApiPolyfill to true to
make sure we always transpile modules, and do not regress behavior.

Fixes emberjs/ember.js#19425

When we released the refactor to transform to module names instead of
the API polyfill, sometimes those modules would transform correctly,
and sometimes they wouldn't. There appears to be a race condition
between `babel-plugin-ember-modules-api-polyfill`, this plugin, and the
AMD module transform.

This PR updates the default for `ensureModuleApiPolyfill` to true to
make sure we always transpile modules, and do not regress behavior.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] New app CI tests broken
2 participants