Skip to content
This repository was archived by the owner on Dec 8, 2024. It is now read-only.

Pass along moduleName as option to precompiler #10

Closed
wants to merge 0 commits into from

Conversation

jasonmit
Copy link

@jasonmit jasonmit commented May 2, 2016

ember-cli-htmlbars also sets moduleName and other transformations may rely on this property.

https://github.com/ember-cli/ember-cli-htmlbars/blob/master/index.js#L69

@pangratz
Copy link
Contributor

pangratz commented May 5, 2016

Thanks @jasonmit!

Do you see a way how this can be tested?

Looking at the line you linked, shouldn't the relative path be used, so something like file.opts.filenameRelative? Did you try this out in a project to see if this works?

@jasonmit
Copy link
Author

jasonmit commented May 5, 2016

I'll see about writing a test tonight, we are using it successfully in one of our apps currently.

As for relative path, I think you're correct since it defaults to the full path so I will make that change also tonight. Good catch

@jasonmit
Copy link
Author

jasonmit commented May 9, 2016

Reopened as #11 with a test and changed to filenameRelative

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants