Dependency Upgrades #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix tests that were mixing done and returning a promise
|
@kturney I think we're not quite ready to drop Node 0.12 support as we want to continue to support older ember-cli versions that may be in use with it. |
|
@kturney Besides that, this is looking good. Thanks for tackling it! |
|
whoops. Sorry. Missed the 0.12 support drop from core-object. I moved back to 2 |
|
@lukemelia any idea why using the same version of core-object as ember-cli-deploy fails here but not there? Maybe 2.0.X is cached on ember-cli-deploy? Should they both be locked to |
|
@kturney not sure. I just kicked the build to see if that does it. We may need to clear the travis cache too. |
|
Thanks for persevering @kturney! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed & Why
Dependency upgrades and a few code changes to work with the upgraded deps.