Large restructure of s3-index plugin #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- keyPrefix is removed. versions are uploaded as filePrefix + ":" + revision - prefix option support. like the s3 plugin, so you can upload to a subdirectory of a bucket - Uses Promise.denodify to reduce LOC and improve readibility - Cleaner line between index.js and s3.js, like in the s3 plugin
Closed
|
Thanks a lot! this looks really great. I'll look at this in more detail this afternoon and merge this later. |
LevelbossMike
added a commit
that referenced
this pull request
Sep 27, 2015
Large restructure of s3-index plugin
|
Thx again. Great PR! |
vitch
pushed a commit
to vitch/ember-cli-deploy-s3-index
that referenced
this pull request
Mar 23, 2017
…cs-18467-deploy-activate-fixes to master * commit '845a854ac5a876d2b86ec621d98d995e144bb799': CS-18467 - Adding a better explanation to the differences between did:activate and --activate CS-18467 - Removing slice in favour of simpler method CS-18467 - Handle deploy:activate for deploy audit logs CS-18467 - Add listObjects and getObject to S3 class Bugfix: Link to the correct lib for audit-log CS-18516 - Dasherive revisionKey for Do It Live URL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings this plugin much more inline with the operation and structure of https://github.com/ember-cli-deploy/ember-cli-deploy-s3
filePattern + ":" + revisiondeploy:listdeploy:listlists revisions in the format expected bydeploy:activate