-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Server Side Encryption #67
Conversation
I just restarted the Travis build and this LGTM. |
@sethpollack as the documentation states that there are only two supported values for the serverside-encryption key and we are asserting on passing Did you check that the plugin still functions as expected without this option present for users that don't need this? (which it should do according to the code changes just asking) |
@@ -55,6 +56,10 @@ module.exports = CoreObject.extend({ | |||
CacheControl: cacheControl | |||
}; | |||
|
|||
if (serverSideEncryption) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we please add a test for this conditional
Just a company policy. Do these changes help? |
@sethpollack tests are failing. I suggest we add two tests to the s3 client to make sure we are only adding this when the serverSideEncryption option is passed (one for not passing the option, one for passing). And the same to index-nodetest. |
Oh oops. Git added it back to the options. This should fix it. I'll add the tests now. |
Actually, I need to add this to the activate hook too. Will push up the changes soon. |
🎉 thank you so much for this contribution @sethpollack |
What Changed & Why
Added an optional param
serverSideEncryption
.PR Checklist