Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing a valid s3client via config #4

Merged
merged 1 commit into from
Sep 25, 2015
Merged

Support passing a valid s3client via config #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ module.exports = {
revisionKey: function(context) {
var revisionKey = context.revisionData && context.revisionData.revisionKey;
return context.commandOptions.revision || revisionKey;
},
s3Client: function(context) {
return context.s3Client; // if you want to provide your own S3 client to be used instead of one from aws-sdk
}
},
requiredConfig: ['accessKeyId', 'secretAccessKey', 'bucket'],
Expand Down
2 changes: 1 addition & 1 deletion lib/s3.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ module.exports = CoreObject.extend({
var config = plugin.pluginConfig;
var readConfig = plugin.readConfig;

this._client = new AWS.S3(config);
this._client = plugin.readConfig('s3Client') || new AWS.S3(config);
this._bucket = plugin.readConfig('bucket');
this._keyPrefix = plugin.readConfig('keyPrefix');
this._filePattern = plugin.readConfig('filePattern');
Expand Down