[BREAKING] Make region a required configuration.
#31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`region` is now a required configuration option which is the same behaviour as in the `ember-cli-deploy-s3`-plugin. This will break deploys that rely on the default region of `us-east-1` but will fail with a useful error message. Closes ember-cli-deploy#30
achambers
pushed a commit
that referenced
this pull request
Dec 16, 2015
[BREAKING] Make `region` a required configuration.
|
👍 |
|
I'm sure I'm just being dense, but where is region actually used in the codebase? |
|
@lukemelia I think you'll find it's here -> https://github.com/ember-cli-deploy/ember-cli-deploy-s3-index/blob/master/lib/s3.js#L27-L30 The config options are just passed straight through to the |
|
Ah, OK. Seems like that is a lot of unintentional API surface area. |
|
mmh. That was actually meant as a way for 'power users' to be able to customize the S3 client. Which might be kind of useless because the other s3 plugin is not providing that option and it now seems more like a YAGNI thing when thinking about it ;) The only thing the other plugins are passing to the S3 client is region and the accessKey stuff correct? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regionis now a required configuration option which isthe same behaviour as in the
ember-cli-deploy-s3-plugin.This will break deploys that rely on the default region of
us-east-1but will fail with a useful error message.Closes #30