Added function keyword #2
Conversation
Trying to install this plugin from github (`ember install ember-cli-deploy/ember-cli-deploy-s3-index`) results in an error: > Unexpected token ( This fixes it and I presume is intended behaviour unless you are somehow running npm through babel? I'm on node `v0.12.7`
|
Ah yes of course. I was developing this with iojs. Sorry for the inconvenience caused and thx for your pr. I'll add tests to the repo this weekend and release the first beta version |
|
Thanks! Side question - should it work as is (with these fixes in place)? It now doesn't error for me but no file is uploaded to my bucket and I'm not sure if it's something I'm doing or something missing from the plugin (I'm also using |
|
I am using this right now in a test application and it works fine. what does your deploy.js look like? |
|
Sorry - PBKAC! I had the wrong bucket name in there (it was uploading to the assets bucket instead of the separate bucket we have set up for the index). Thanks! |
|
ok great to hear! Please let me know of any issues you run into. I'll release the first beta this weekend so just ping me if you run into problems so we can sort them out asap |
|
Will do - thanks 😃 |
…sync-aws-dotenv-with-boto to master * commit 'd8f88377bec1dece65d1a368ee1479e16cc5b0e3': Use Boto's env var name, rather than our own
…g from feature/cs-18036-active-revision to master * commit '84c78fdc9e0b9fb601f178489c7138fec63a077c': CS-18036 - Addressing CR feedback Linting fixes CS-18036 - Add Author Date and Commiter Date to the returns commit json CS-18036 - Create an active-revision.json file on didActivate so we can easily display the active version from swift-ui list CS-18036 - Bugfix: check for when no intital revisions are availble
Trying to install this plugin from github (
ember install ember-cli-deploy/ember-cli-deploy-s3-index) results in an error:This fixes it and I presume is intended behaviour unless you are somehow running npm through babel? I'm on node
v0.12.7