Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep modification time the same as the original file #33

Merged
merged 3 commits into from
Nov 24, 2020

Conversation

avdv
Copy link
Contributor

@avdv avdv commented Jun 5, 2020

What Changed & Why

See #32 for the rational.

Copying the modification from the original file should have no bad effects, so it is not necessary being able to introduce a config option for this, IMO.

Also, I have not made it fail if reading / writing the timestamp errors out for some reason.

Related issues

PR Checklist

  • Add tests
  • Add documentation
  • Prefix documentation-only commits with [DOC]

People

Mention people who would be interested in the changeset (if any)

@caljess599 FYI

@avdv
Copy link
Contributor Author

avdv commented Jun 8, 2020

Seems like the travis job failed. Maybe bump the node js version to 8 ?

Context: https://travis-ci.org/github/ember-cli-deploy/ember-cli-deploy-gzip/builds/695015670

[3/5] Fetching packages...

error [email protected]: The engine "node" is incompatible with this module. Expected version ">=8.0.0". Got "6.17.1"

error Found incompatible module.

@lukemelia lukemelia merged commit cef0f64 into ember-cli-deploy:master Nov 24, 2020
@avdv avdv deleted the keep-mtime branch November 24, 2020 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants