Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why compress jpg, png and gif? #14

Closed
buschtoens opened this issue Dec 21, 2015 · 1 comment
Closed

Why compress jpg, png and gif? #14

buschtoens opened this issue Dec 21, 2015 · 1 comment

Comments

@buschtoens
Copy link

I just saw that jpg, png and gif images are compressed by default. These formats already are compressed and it is unlikely that gzipping them will reduce the file size. In fact, it might even increase it and / or introduce a slight performance regression on the client-side due to the added (and unnecessary) CPU work.

If this is a mistake and not intended, I'll submit a PR to fix this - if wanted.
@lukemelia
Copy link
Collaborator

@buschtoens Excellent point. I agree with your analysis. We should change the defaults and a PR for this would be most welcome.

buschtoens pushed a commit to buschtoens/ember-cli-deploy-gzip that referenced this issue Dec 21, 2015
fix ember-cli-deploy#14: only compress uncompressed files
f64a845
@buschtoens buschtoens mentioned this issue Dec 21, 2015
Merged
lukemelia added a commit that referenced this issue Dec 21, 2015
@lukemelia
Merge pull request #15 from buschtoens/fix-14-wrong-default-file-pattern
98367fc 
Fix #14: only compress uncompressed files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lukemelia @buschtoens