Drop support for ember-element-helper <= 0.6.0 #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villander
approved these changes
Dec 4, 2023
|
Really need this in! @SergeAstapov any updates? |
SergeAstapov
approved these changes
Dec 27, 2023
|
this landed in #672 |
|
Thanks @SergeAstapov! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a forced-hand solution to #594, and supercedes #647.
This drops support for
ember-element-helper<= 0.6.0since there doesn't seem to be a good way to dynamically remove support for it during build time with ember macros at the moment. I've created an issue in embroider, but I'm not sure how long it will take to have a solution.0.6.0is almost two years old at this point, and continuing to support it in this library doesn't seem like it's worth it at this point. Happy to discuss!