Convert addon setup to monorepo #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we disabled `ENV.EmberENV.RAISE_ON_DEPRECATION`, now we can have FastBoot tests passing
SergeAstapov
force-pushed
the
convert-monorepo
branch
2 times, most recently
from
1ff0caa to
3895c01
Compare
SergeAstapov
commented
Feb 18, 2022
package.json
Outdated
| "resolutions": { | ||
| "@ember/legacy-built-in-components": "github:emberjs/ember-legacy-built-in-components#a84513d197eeafbb01eae81e0f101b86ccde0ecf", | ||
| "@ember/render-modifiers": "github:SergeAstapov/ember-render-modifiers#ember-source-asterisk", | ||
| "ember-element-helper": "github:SergeAstapov/ember-element-helper#ember-source-asterisk", |
There was a problem hiding this comment.
@ef4 FYI could not get peer deps working with pnpm as anticipated so found out it's enough to change ember-source in peerDependencies of @ember/render-modifiers and ember-element-helper
I'm not 100% confident this will always work as expected so will keep looking into pnpm.
meanwhile build is green and I can safely start actual v2 conversion
This was referenced Feb 22, 2022
SergeAstapov
force-pushed
the
convert-monorepo
branch
from
15ce491 to
220f996
Compare
SergeAstapov
force-pushed
the
convert-monorepo
branch
from
220f996 to
30ea400
Compare
SergeAstapov
force-pushed
the
convert-monorepo
branch
from
d3b9ccc to
caadd78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows Porting an Addon to V2 guide