Fixes currentRouteName middleware reporter test failures #491
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #489.
The recent release of
@ember/test-helpers
v2.9.0 added an assertion error that is emitted if the route name isn't available for a particular test. This results in a slew of unrelated application test failures when running the middleware reporter.The resulting test failures typically consist of:
The fix introduces a loose wrapper around the
currentRouteName
call, which absorbs the error, preventing it from getting emitted up to the test scope. All other behavior remains unchanged.