Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ember-auto-import to 2.2.4 and introduce webpack #325

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Bump ember-auto-import to 2.2.4 and introduce webpack #325

merged 1 commit into from
Dec 13, 2021

Conversation

SergeAstapov
Copy link
Contributor

There is bunch of wins, greatly summarized by @buschtoens in https://twitter.com/buschtoens/status/1449745394594889734

@MelSumner MelSumner requested a review from drewlee December 13, 2021 21:17
Copy link
Member

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinging @drewlee here too

Do we think this should target a new major version branch?

@scalvert
Copy link
Contributor

What would this need to be a major for, @MelSumner?

@scalvert
Copy link
Contributor

Is it this:

https://github.com/ef4/ember-auto-import/blob/main/docs/upgrade-guide-2.0.md#quick-summary

addons that upgrade to ember-auto-import >= 2 will only work in apps that have ember-auto-import >= 2, so they should do their own semver major releases when they upgrade

(I'll be honest, this dependency hell really confuses me :))

@SergeAstapov
Copy link
Contributor Author

@scalvert yes, per above link you posted this is a breaking change hence needs a major.
If there is anything else slated for next major - I would be happy to help

@scalvert scalvert merged commit e24c942 into ember-a11y:master Dec 13, 2021
@SergeAstapov SergeAstapov deleted the upgrade-ember-auto-import-v2 branch December 13, 2021 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants