Fix for is prop collisions. (#60)

* Fix for `is` prop collisions. * add changeset * Update docs.
embellishing · Jul 6, 2024 · f88ed60 · f88ed60
1 parent 4c18c0e
commit f88ed60
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 8 deletions.
diff --git a/.changeset/seven-books-taste.md b/.changeset/seven-books-taste.md
@@ -0,0 +1,5 @@
+---
+"@embellish/react": patch
+---
+
+Fixed a potential \`is\` prop collision issue.
diff --git a/docs/api/react.componentprops.md b/docs/api/react.componentprops.md
@@ -14,7 +14,9 @@ P,
 C extends string,
 Is extends keyof JSX.IntrinsicElements | React.JSXElementConstructor<any>,
 InlineConditionName extends string,
-OwnProps = (string extends C
+OwnProps = {
+    is?: Is;
+} & (string extends C
 ? unknown
 : {
     conditions?: {
@@ -35,9 +37,7 @@ Partial<{
     ? P[PropName]
     : never;
 }>,
-> = {
-    is?: Is;
-} & Omit<
+> = Omit<
 JSX.LibraryManagedAttributes<Is, ComponentPropsWithRef<Is>>,
 keyof OwnProps
 > &

diff --git a/packages/react/src/component.d.ts b/packages/react/src/component.d.ts
@@ -61,7 +61,9 @@ export type ComponentProps<
   C extends string,
   Is extends keyof JSX.IntrinsicElements | React.JSXElementConstructor<any>,
   InlineConditionName extends string,
-  OwnProps = (string extends C
+  OwnProps = {
+    is?: Is;
+  } & (string extends C
     ? unknown
     : {
         conditions?: {
@@ -82,9 +84,7 @@ export type ComponentProps<
           ? P[PropName]
           : never;
     }>,
-> = {
-  is?: Is;
-} & Omit<
+> = Omit<
   JSX.LibraryManagedAttributes<Is, ComponentPropsWithRef<Is>>,
   keyof OwnProps
 > &