-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Danish Discourse dataset #247
Add Danish Discourse dataset #247
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Generally, I would like a performance metric on some models as well (but we already looked over those).
@imenelydiaker adding you as a reviewer as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually just realized that we also need the update to the table in the readme with the dataset (I will add that to the guide as well)
Co-authored-by: Kenneth Enevoldsen <[email protected]>
Co-authored-by: Kenneth Enevoldsen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some comments, else everything looks good ! Nice job 😄
from datasets import load_dataset | ||
from sentence_transformers import SentenceTransformer | ||
|
||
from mteb.abstasks.AbsTaskClassification import AbsTaskClassification |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from mteb.abstasks.AbsTaskClassification import AbsTaskClassification | |
from ...abstasks import AbsTaskClassification |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to prefer this?
Co-authored-by: Imene Kerboua <[email protected]>
Co-authored-by: Imene Kerboua <[email protected]>
Co-authored-by: Imene Kerboua <[email protected]>
Awaiting license from @KennethEnevoldsen. Feel free to nitpick, want to do this right 👍