Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RawU18, use RawU24 instead #660

Merged
merged 3 commits into from
Mar 25, 2022
Merged

Remove RawU18, use RawU24 instead #660

merged 3 commits into from
Mar 25, 2022

Conversation

jamwaffles
Copy link
Member

@jamwaffles jamwaffles commented Mar 24, 2022

Thank you for helping out with embedded-graphics development! Please:

  • Check that you've added passing tests and documentation
  • Add a CHANGELOG.md entry in the Unreleased section under the appropriate heading (Added, Fixed, etc) if your changes affect the public API
  • Run rustfmt on the project
  • Run just build (Linux/macOS only) and make sure it passes. If you use Windows, check that CI passes once you've opened the PR.

PR description

Closes #657

@jamwaffles jamwaffles marked this pull request as ready for review March 24, 2022 21:11
@jamwaffles jamwaffles requested a review from rfuest March 24, 2022 21:11
Copy link
Member

@rfuest rfuest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small issues with the changelog, otherwise it looks good.

core/CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@jamwaffles jamwaffles merged commit a201f91 into master Mar 25, 2022
@jamwaffles jamwaffles deleted the remove-rawu18 branch March 25, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove RawU18
2 participants