Use Rectangle for Dimensions trait #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamwaffles
reviewed
Apr 6, 2020
| } | ||
| for p in item.primitive.bounding_box().points() { | ||
| if let Some(pixel) = self.get_pixel_mut(p) { | ||
| pixel.copy_from_slice(color); |
jamwaffles
reviewed
Apr 6, 2020
|
|
||
| fn size(&self) -> Size { | ||
| self.primitive.size() | ||
| //FIXME: The bounding box for a styled primitive should use the stroke width and alignment. |
There was a problem hiding this comment.
If you're not going to fix this soon, can you create an issue so it doesn't get forgotten about please?
There was a problem hiding this comment.
These should be fixed soon, but I've started a tracking issue for these changes.
jamwaffles
reviewed
Apr 6, 2020
Comment on lines
+91
to
+92
| //FIXME: This temporary method replicates the old broken conversion from diameter to size and | ||
| //should be removed. |
There was a problem hiding this comment.
As with the other comment, please open an issue if this won't be fixed in the immediate future.
jamwaffles
approved these changes
Apr 6, 2020
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thank you for helping out with Embedded Graphics development! Please:
CHANGELOG.mdentry in the Unreleased section under the appropriate heading (Added, Fixed, etc) and appropriate crate (embedded-graphics,simulator,tinytga,tinybmp) if your changes affect the public APIrustfmton the project./build.sh(Linux/macOS only) and make sure it passes. If you use Windows, check that CI passes once you've opened the PR.PR description
This PR changes the
Dimensionstrait to return aRectangleinstead of providing separate methods for getting the corners and size. This reduces code duplication and makes it easier to get consistent behavior that should match #182.One example of how this PR can simplify code is the change in
simulator/src/framebuffer.rs. It uses the newPointsiterator to iterate over all pixels inside the bounding box.The
Dimensionimplementation forCirclewas broken before this PR and wasn't fixed in the PR to keep the scope of this PR smaller. I'll open another PR after this one is merged.