Switch to async-fn-in-trait #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dirbaio
force-pushed
the
afit
branch
2 times, most recently
from
1e1b639 to
90ba465
Compare
bors bot
added a commit
to rust-embedded/embedded-hal
that referenced
this pull request
Nov 23, 2022
407: async: switch to async-fn-in-traits, release v0.2.0-alpha.0 r=eldruin a=Dirbaio Latest Rust nightlies have somewhat usable async-fn-in-trait support already! 🎉 embassy-nrf updated here embassy-rs/embassy#974 Paprecuts encountered: - there's this annoying error [playground](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=f04fca1f2a3d643c323fb49c05bd3ed3), workaround is to use the concrete type instead of `Self::Error`. This is a limitation of all `async fn`s, not just in traits, but it hits especially hard within traits, so I dunno if there's plans to improve it. > `async fn` return type cannot contain a projection or `Self` that references lifetimes from a parent scope - The SpiDevice trait ICEs, issue filed rust-lang/rust#102310 - default methods don't work, but there's a PR already rust-lang/rust#102308 Due to the last 2 I've left `SpiDevice` alone for now. Co-authored-by: Dario Nieuwenhuis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires rust-embedded/embedded-hal#407
Requires rust-embedded-community/embedded-nal#78