Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: DATA-526
Description of Changes
There was a memory leak resulting from the recent performance changes due to circular
shared_ptr
s. This fixes the issue by storingweak_ptr
s to thevector
ofRosValue
s and then having any interfaces that access theRosValue
slock
theweak_ptr
and return aRosValuePointer
which stores the lockedweak_ptr
(which is just ashared_ptr
).Test Plan
Tests + ensured that
-fsanitize=address
does not show any errors.