Minor cleanup

embarktrucks · Dec 3, 2021 · e331552 · e331552
1 parent f33221b
commit e331552
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/lib/message_parser.cc b/lib/message_parser.cc
@@ -17,7 +17,7 @@ const RosValue::RosValuePointer MessageParser::parse() {
   ros_values_->emplace_back(msg_def_.fieldIndexes());
   ros_values_offset_ = 1;
   initObject(0, msg_def_);
-  return RosValue::RosValuePointer(ros_values_, 0);
+  return RosValue::RosValuePointer(ros_values_);
 }
 
 void MessageParser::initObject(size_t object_offset, const RosMsgTypes::BaseMsgDef &object_definition) {

diff --git a/lib/ros_value.h b/lib/ros_value.h
@@ -20,7 +20,12 @@ class RosValue {
     {
     }
 
-    RosValuePointer(std::weak_ptr<std::vector<RosValue>> base, size_t index)
+    RosValuePointer(const std::weak_ptr<std::vector<RosValue>>& base)
+      : RosValuePointer(base, 0)
+    {
+    }
+
+    RosValuePointer(const std::weak_ptr<std::vector<RosValue>>& base, size_t index)
       : VectorItemPointer<RosValue>(base.lock(), index)
     {
     }

diff --git a/lib/util.h b/lib/util.h
@@ -37,13 +37,13 @@ class VectorItemPointer {
   size_t index;
 
  public:
-  VectorItemPointer(std::shared_ptr<std::vector<T>> base, size_t index)
+  VectorItemPointer(const std::shared_ptr<std::vector<T>>& base, size_t index)
   : base(base)
   , index(index)
   {
   }
 
-  VectorItemPointer(std::weak_ptr<std::vector<T>> base, size_t index)
+  VectorItemPointer(const std::weak_ptr<std::vector<T>>& base, size_t index)
   : VectorItemPointer(base.lock(), index)
   {
   }