Fix #47 and #70

[timotheeguerin]

I added a few features trying to fix #47 and #70.

• Subclasses the 2 error classes with TOML::Errror (Create TOML::Error as a base class for all errors #70)
• Added a list of valid file to be parsed with toml and the json equivalent. Unit test is testing against each file.
• This lead to a few unsupported feature:
  • Unicode escape characters(\u03B4)
  • Empty multiline expression(""""""")
• I also replaced Unit::Test with Minitest::Test which i think is now recommended over Unit::Test
• The error ValueOverwriteError was too strict. The following was failing to parse but is suppose to work:

[a.b.c]
answer = 42

[a]
better = 43

• Having spaces in keys withour quotes is supposed to raise an error [invalid key] ["valid key"] so modified the grammar to be more strict. (check test/examples/invalid/table-whitespace.toml)

If anything seems wrong, tell me and I will fix it.

[houndci-bot]

Extra blank line detected.

[emancu]

Why do you say that minitest is better ?
Honestly I didn't use minitest because I wanted to keep simple the gems dependencies even for dev.

Anyways, it's ok, I just wonder why did you need it?

[timotheeguerin]

If you look on the unit::test documentation http://ruby-doc.org/stdlib-2.1.1/libdoc/test/unit/rdoc/Test/Unit.html it state If you are writing new test code, please use MiniTest instead of Test::Unit.

[emancu]

You have a good point. 👍

[emancu]

Awesome PR!!

Thank you very much for taking care of those issues, I was a little busy to do it.

Let me know when its ready to be merged.

[timotheeguerin]

On the other hand keeping test_grammar allow to test more specific case. Also I could not test the datetime parsing automaticaly with json comparing as json doesn't support it so we need to keep test_datetime at least. I can look into refactoring and removing duplicates after.

[timotheeguerin]

Also I was wondering why you where using dep instead of bundler as they will only be used for contributing and most people use bundler anyway.

[emancu]

I'm ok leaving test_grammar for specific cases.

In the other hand, about bundler let me suggest you a blog post: http://bits.citrusbyte.com/managing-ruby-dependencies

tl;dr Bundler is a very big dependency that solves a lot of problems that I don’t have

[emancu]

Why is this needed?

[timotheeguerin]

i forgot to remove pp it i was trying to have a better compare view of the json and toml in case they differ but pp doesn't seem to improve much.

And i need json to parse the json file

[timotheeguerin]

Thanks for the article, I see your point.

[emancu]

Is it ready for merge ?

On Monday, June 8, 2015, Timothee Guerin [email protected] wrote:

Thanks for the article, I see your point.

—
Reply to this email directly or view it on GitHub
#71 (comment).

Emiliano Mancuso http://about.me/emancu

[timotheeguerin]

It should unless you need anything else