-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promises reworked, menubar functionality in events/options improved #30
Open
shoshins
wants to merge
16
commits into
emadalam:Milestone-Enhancements
Choose a base branch
from
shoshins:Milestone-Enhancements
base: Milestone-Enhancements
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 15 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
52df982
promises reworked in:
shoshins 8fe2bdd
promise catch converted to right approach in handler.
shoshins b479602
menu default loading/error templates removed as redundant
shoshins f1c1255
page - ready/afterready async/sync modes are combined with 'when'.
shoshins 2fbb10f
page - 'when' removed for ready/afterready. 'then' used instead of.
shoshins b17f3a3
page example doc updated for a new promises
shoshins f84bc07
redundant promise.resolve removed
shoshins 393332a
navigate promise improved (sync part moved to promise)
shoshins 6a91a24
ready/afterready - async sync mode fixed
shoshins ae61092
onMenuItemSelect promises clean up & order fixed
shoshins 419dbf6
promises callbacks improved
shoshins 7e5949e
1) 'options' parameters for page invocation (ready event) 2) custom m…
shoshins 6c1d029
dist folder sync with latest changes (options & custom menu)
shoshins 4779c41
babel polyfill check already included check
shoshins 994907f
version updated to 0.2.6
shoshins ae0b460
#30 major version updated
shoshins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest update major version because of breaking changes in this PR.
Here are major semver rules:
1.X.X
— Major update for breaking changes. Even if they are mostly backward compatibleX.1.X
— Minor update for new features with backward compatibility.X.X.1
— Patch update only for bugfixes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's true. I could not afford to change major version of library that was created by another person)