Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add haskell support #16

Closed
wants to merge 4 commits into from
Closed

Conversation

quangIO
Copy link

@quangIO quangIO commented Jun 7, 2021

No description provided.

@@ -92,6 +92,7 @@ See `tree-sitter-langs-repos'."
(css-mode . css)
(elm-mode . elm)
(go-mode . go)
(haskell-mode . haskell)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to align this? :)

@ubolonton
Copy link
Collaborator

ubolonton commented Aug 9, 2021

Thanks for the PR!
Haskell grammars seem to be broken on some platforms though.
I'll check this after the CI pipelines are fixed. They are currently broken after this repo is moved to an org.

@quangIO
Copy link
Author

quangIO commented Aug 9, 2021

On MacOS, I think the CI also need to use gcc instead of clang. E.g. brew install gcc && ln -sf /usr/local/bin/gcc-11 /usr/local/bin/gcc

@iyefrat
Copy link

iyefrat commented Aug 22, 2021

This PR seems to have passed CI. Has the problem been fixed or is this a false positive or something?

Also @quangIO there's a merge conflict now.

Thanks for submitting this! Can't wait for it to get merged.

Edit: ah, it seems that the successful CI is from when this PR was first submitted, which was before the move to an org. my bad.

@ubolonton
Copy link
Collaborator

Yeah, it passed when CI was not properly set up to fail on errors.

@iyefrat
Copy link

iyefrat commented Aug 26, 2021

Is the CI set up properly now? given the fact that this pr is not that complicated but needs to have conflicts fixed, I'd be glad to submit a conflict-free version if it could get in that way.

@quangIO quangIO force-pushed the master branch 2 times, most recently from df5f5e2 to 6d4c40d Compare August 26, 2021 17:18
@quangIO
Copy link
Author

quangIO commented Aug 26, 2021

@iyefrat I resolved the conflict. However, CI could still fail. Since Haskell isn't my main programming languages nowadays, if you want to continue to work on this, perhaps you could help me fix the CI (I am not familiar with Azure Pipeline). Note that tree-sitter-haskell uses gcc and needs at least C++14.

By the way, the CI takes forever to build Emacs. We should have some caching to save build time

@ubolonton
Copy link
Collaborator

Note that tree-sitter-haskell uses gcc and needs at least C++14.

Thanks for investigating!

By the way, the CI takes forever to build Emacs. We should have some caching to save build time

It was originally set up to build Emacs from source because most distros disabled dynamic module support. Perhaps that has changed, in which case we don't need to build Emacs from source anymore.

@ZachFontenot
Copy link
Contributor

Hey there, I haven't looked into the particulars, but maybe this PR tree-sitter/tree-sitter-haskell#62 has made it easier to build this?

@ubolonton
Copy link
Collaborator

Thanks for the info. I added it in #70.

@ubolonton ubolonton closed this Jan 27, 2022
@unhammer
Copy link

It's missing the queries and entry in tree-sitter-langs--init-major-mode-alist though. I just tried it, and it seems to work, even handles TemplateHaskell better than the regular emacs haskell-mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants