-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add haskell support #16
Conversation
tree-sitter-langs.el
Outdated
@@ -92,6 +92,7 @@ See `tree-sitter-langs-repos'." | |||
(css-mode . css) | |||
(elm-mode . elm) | |||
(go-mode . go) | |||
(haskell-mode . haskell) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to align this? :)
Thanks for the PR! |
On MacOS, I think the CI also need to use gcc instead of clang. E.g. |
This PR seems to have passed CI. Has the problem been fixed or is this a false positive or something? Also @quangIO there's a merge conflict now. Thanks for submitting this! Can't wait for it to get merged. Edit: ah, it seems that the successful CI is from when this PR was first submitted, which was before the move to an org. my bad. |
Yeah, it passed when CI was not properly set up to fail on errors. |
Is the CI set up properly now? given the fact that this pr is not that complicated but needs to have conflicts fixed, I'd be glad to submit a conflict-free version if it could get in that way. |
df5f5e2
to
6d4c40d
Compare
@iyefrat I resolved the conflict. However, CI could still fail. Since Haskell isn't my main programming languages nowadays, if you want to continue to work on this, perhaps you could help me fix the CI (I am not familiar with Azure Pipeline). Note that tree-sitter-haskell uses gcc and needs at least C++14. By the way, the CI takes forever to build Emacs. We should have some caching to save build time |
Thanks for investigating!
It was originally set up to build Emacs from source because most distros disabled dynamic module support. Perhaps that has changed, in which case we don't need to build Emacs from source anymore. |
Hey there, I haven't looked into the particulars, but maybe this PR tree-sitter/tree-sitter-haskell#62 has made it easier to build this? |
Thanks for the info. I added it in #70. |
It's missing the queries and entry in |
No description provided.