replace shell-command-on-region by call-process-region #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zonuexe I've also been using this for some days and have not noticed any bad side effect. Thus, I plan to merge this PR this evening (Finnish time) |
shell-command-on-region is meant for interactive use, causing a buffer to popup now and then. Using call-process-region instead removes this disturbing behaviour.
kermorgant
force-pushed
the
phpactor-invocation
branch
from
7f3c833 to
ed4b0e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shell-command-on-region is meant for interactive use, causing a buffer
to popup now and then. This commit removes this disturbing behaviour.