Fix emacs native compilation warning #136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To reproduce, have emacs built with native compilation and notice the compilation logs. You can then open the offending file and run `M-x emacs-lisp-native-compile-and-load` before and after the changes to see the warning is removed. ``` ■ Warning (comp): lsp-treemacs.el:652:2: Warning: docstring wider than 80 characters ■ Warning (comp): lsp-treemacs.el:982:2: Warning: docstring wider than 80 characters ■ Warning (comp): lsp-treemacs.el:992:2: Warning: docstring wider than 80 characters ```
``` Unmatched website URL ’https://github.com/emacs-lsp/lsp-treemacs’; add (website-url "https://github.com/emacs-lsp/lsp-treemacs") to Eask-file Unmatched keyword ’languages’; add (keywords ... "languages") to Eask-file or consider removing it ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce, have emacs built with native compilation and notice the compilation logs. You can then open the offending file and run
M-x emacs-lisp-native-compile-and-loadbefore and after the changes to see the warning is removed.Also fixes some eask specific warnings:
There are also other emacs 29 warnings present but those need to be fixed in treemacs.