Disable splitting of floating frames #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, floating frames were configured to never automatically split, but they could be manually split (usually by accident). * exwm-floating.el (exwm-floating--set-floating): disable splitting of floating windows by setting a the `split-window' window parameter to a function that always throws an error.
|
I am not sure. Maybe one can consider this a feature, not a bug? Otoh floating windows are mostly temporary dialogs, so allowing splits may lead to confusion. (#63 seems related) |
|
At the moment we're in kind of an awkward world where floating frames are mostly dedicated, but not 100%. I'd prefer to just make it consistent. In terms of #63, I'd make those frames unsplittable as well (just with an Emacs buffer instead of an X buffer). |
|
Okay, sounds good. Let's go with your patch then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, floating frames were configured to never automatically split, but they could be manually split (usually by accident).