Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer surrogate minibuffers to the next workspace on delete #74

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

Stebalien
Copy link
Contributor

Othewise, we won't be able to delete the frame (frames with surrogate minibuffers cannot be deleted).

  • exwm-workspace.el (exwm-workspace-delete): Transfer surrogate minibuffers to the next workspace before attempting to delete a workspace (part of Corfu, posframe, and child frames #64). (exwm-workspace--prompt-delete): Use exwm-workspace-delete' instead of directly calling delete-frame'.

Othewise, we won't be able to delete the frame (frames with surrogate
minibuffers cannot be deleted).

* exwm-workspace.el
(exwm-workspace-delete): Transfer surrogate minibuffers to the next
workspace before attempting to delete a workspace (part of #64).
(exwm-workspace--prompt-delete): Use `exwm-workspace-delete' instead of
directly calling `delete-frame'.
@Stebalien Stebalien requested a review from minad August 18, 2024 14:34
@Stebalien Stebalien merged commit 8c61f7e into master Aug 18, 2024
@Stebalien Stebalien deleted the steb/transfer-minibuffers branch August 18, 2024 14:35
@Stebalien
Copy link
Contributor Author

(I'll take the 👍 as "good to merge")

@minad
Copy link
Member

minad commented Aug 18, 2024

(I'll take the 👍 as "good to merge")

Absolutely. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants