Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix on-Notify #71

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Fix on-Notify #71

merged 1 commit into from
Jul 18, 2024

Conversation

mgi
Copy link
Contributor

@mgi mgi commented Jul 18, 2024

I don't know if it has ever worked (unless there was a change in `cl-case' semantic).

I don't know if it has ever worked (unless there was a change in
`cl-case' semantic).
@minad
Copy link
Member

minad commented Jul 18, 2024

We have several uses of cl-case in the code base. Maybe we should replace all of them with pcase?

@mgi
Copy link
Contributor Author

mgi commented Jul 18, 2024

I don't know… maybe. But for this case, a simple cond does the trick.

@mgi
Copy link
Contributor Author

mgi commented Jul 18, 2024

I forgot to say that this patch fixes a regression for me: I'm switching back and forth between the laptop screen and an external one with calls to xrandr scripts. Without this patch, EXWM does not adapt its resolution when switching (it was on 0.30).

@Stebalien
Copy link
Contributor

All the other cl-case instances look correct (they're matching on symbols).

@Stebalien
Copy link
Contributor

(let's merge this one as-is because it's fixing a bug, we can replace everything with pcases in a separate patch if desirable)

@Stebalien Stebalien merged commit f00b5ca into emacs-exwm:master Jul 18, 2024
@mgi
Copy link
Contributor Author

mgi commented Jul 18, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants