Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the goto-reference in slime-mode only works for global variables. #853

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

sakurawald
Copy link
Contributor

@sakurawald sakurawald commented Dec 22, 2024

Brief summary of what the package does

Fix the binding of goto reference in slime mode.
The command slime-who-references is not the proper command to find the references on a symbol.
Actually, the slime-who-references only works on global variables, it doesn't works for functions, methods and class.
As documented:

slime-who-references is an interactive byte-compiled Lisp function in
‘slime.el’.

It is bound to g r, <normal-state> g r, C-c C-w C-r and C-c C-w r.

(slime-who-references SYMBOL)

Show all known referrers of the global variable SYMBOL.

[back]

The command slime-edit-uses is an all-in-one command, that does combines all the commands to find the references on a symbol, including: a variable, a function, a method, a class, a specializer.

As documented:

slime-edit-uses is an interactive byte-compiled Lisp function in
‘slime.el’.

It is bound to M-? and M-_.

(slime-edit-uses SYMBOL)

Lookup all the uses of SYMBOL.

[back]

Direct link to the package repository

https://github.com/slime/slime

Checklist

Assume you're working on mpc mode:

  • byte-compiles cleanly
  • M-x checkdoc is happy. Don't manually write (provide 'evil-collection-mpc), M-x checkdoc can do it automatically for you
  • define evil-collection-mpc-setup with defun
  • define evil-collection-mpc-mode-maps with defconst
  • All functions should start with evil-collection-mpc-

@sakurawald
Copy link
Contributor Author

The CI seems down, @condy0919

Run make install
eask install-deps --dev
Loading package information... done ✓
Installing 2 package dependencies...

  - [1/2] Installing evil (20250105.2230)... done ✓
  - [2/2] Installing annalist (20240501.1201)... done ✓

(Total of 2 dependencies installed, 0 skipped)

Installing 4 development dependencies...

  - [1/4] Installing f (20241003.1131)... done ✓
  - [2/4] Installing ert-runner (20231110.1358)... done ✓
  - [3/4] Installing package-lint (20241127.182[6](https://github.com/emacs-evil/evil-collection/actions/runs/12450929770/job/35176323329#step:6:7))... https://elpa.gnu.org/packages/let-alist-1.0.6.tar: Bad Request
make: *** [Makefile:[7](https://github.com/emacs-evil/evil-collection/actions/runs/12450929770/job/35176323329#step:6:8): install] Error -1
Error: Process completed with exit code 1.

@condy0919
Copy link
Collaborator

This problem often occurs and can be ignored

@condy0919 condy0919 merged commit 5876649 into emacs-evil:master Jan 7, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants