feat: Integrate Ojo oracle module #1102
Conversation
|
Prepared test commands: The commands above utilizes the latest mainnet snapshot in order to test out the new functionality on LocalNet with mainnet data. Doing so resulted with the following error: I created a new PR (#1126) to resolve conflicts and errors: still a WIP. This should also help in building a new snapshot with the updated Ojo oracle module. I’ll likely need to remove the Elys Oracle module from the store upgrades and replace it with the new Ojo Oracle module for this to work. Additionally, I’ve opened another PR (elys-network/post-upgrade-snapshot-generator#97) to update the CI workflow for supporting the new price feeder flags. This will allow us to test the new PR and generate snapshots. |
|
@rbajollari the previous issue was fixed by initializing the default values of the parameters of the module: now I am getting a different error from I will continue to investigate why this is happening. let me know if you have any insights on that issue. |
|
@rbajollari the issue seems to occur in |
Updated our oracle endblocker so it doesn't error out and stop the chain if that error can't get the validators yet 👍 |
thanks @rbajollari I managed to get the chain running with your latest changes I am seeing this error now: even though the AMM pool does have the pool id 1 set: same for accounted pool module: here are my localnet settings for the oracle module: I am setting them here for my tests https://github.com/elys-network/elys/pull/1126/files#diff-0f1d2976054440336a576d47a44a37b80cdf6701dd9113012bce0e3c425819b7R360-R459 also I noticed both @rbajollari can you help clarify why that might happen? |
I pushed some changes in the amm endblocker which makes sure that the oracle's module kvstore has that pool information which the price feeder uses for getting the liquidity data. That fixes the pool not being found error. As far as the prices not showing up I think that might be from the oracle params you're setting (specifically the currency provider pairs) not giving enough providers for the price feeder to run correctly. Can you try it again just setting the oracle params to their default values? |
@rbajollari thanks for those changes, I am not getting the even though I set both ATOM and USDC asset infos as shown in my test branch here 0b0bf64 do you have any idea why this is happening? thanks |
Looks like the price feeder logic I copied over from the elys price feeder fork requires the USDC_DENOM to be set in the env variable before running it. I ran |
Description
Closes:
Steps to test locally
What has Changed?
What specific problem were you aiming to address, and how did you successfully resolve it? If tests were not uploaded for this pull request or if coverage decreased, please provide an explanation for the change.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking changeDeployment Notes
Are there any specific considerations to take into account when deploying these changes? This may include new dependencies, scripts that need to be executed, or any aspects that can only be evaluated in a deployed environment.
Screenshots and Videos
Please provide any relevant before and after screenshots by uploading them here. Additionally, demo videos can be highly beneficial in demonstrating the process.