Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Node.js version 18 (or later) in preparation for version 16 EOL #3118

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

ptitzler
Copy link
Member

@ptitzler ptitzler commented Mar 1, 2023

Closes #3104

What changes were proposed in this pull request?

  • Replace all references to Node.js version 16+ to Node.js version 18+

CI setup does not require updates because version 18 or later is already used

How was this pull request tested?

👀

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@ptitzler ptitzler added area:documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file labels Mar 1, 2023
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ptitzler ptitzler merged commit 473a3a1 into elyra-ai:main Mar 7, 2023
@ptitzler ptitzler deleted the rip-nodejs-16 branch March 7, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for Node.js v16 (EOL)
2 participants