Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jupyter-server-terminal cap and fix release script #3057

Merged
merged 2 commits into from
Dec 14, 2022

Conversation

akchinSTC
Copy link
Member

@akchinSTC akchinSTC commented Dec 14, 2022

Signed-off-by: Alan Chin [email protected]

What changes were proposed in this pull request?

How was this pull request tested?

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@akchinSTC akchinSTC added priority:high component:build build and build related issues(dependencies and docker) labels Dec 14, 2022
@akchinSTC akchinSTC requested a review from ptitzler December 14, 2022 21:15
Copy link
Member

@ptitzler ptitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Terminal appears to be working again. Would be nice to add a comment to the Makefile indicating that the command is expected to fail, referencing the issue you've created.

@akchinSTC akchinSTC merged commit 5f15573 into elyra-ai:main Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:build build and build related issues(dependencies and docker) priority:high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants