Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip DisableNodeCaching instance conversion on subsequent attempts #2981

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

kiersten-stokes
Copy link
Member

Fixes #2979

What changes were proposed in this pull request?

For pipeline export and submit, a PipelineDefinition object is initialized multiple times. Any property that is converted to an ElyraProperty, however, only needs to be converted once. An attempt to convert what is already an ElyraProperty will result in unexpected behavior, as seen in #2979. This case is already covered for all properties besides DisableNodeCaching here.

Because DisableNodeCaching currently requires special handling (until #2969 is closed), the same if statement linked previously is also added to it's one-off get_single_instance method.

How was this pull request tested?

Tested manually, confirming that pipelines.kubeflow.org/max_cache_staleness: P0D appears in the YAML.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@kiersten-stokes kiersten-stokes added kind:bug Something isn't working component:pipeline-editor pipeline editor labels Oct 25, 2022
@kiersten-stokes kiersten-stokes added this to the 3.13.0 milestone Oct 25, 2022
@elyra-bot
Copy link

elyra-bot bot commented Oct 25, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@ptitzler ptitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akchinSTC akchinSTC merged commit 49ad9e8 into elyra-ai:main Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:pipeline-editor pipeline editor kind:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: 'Disable node caching' property value is always set to False
3 participants