Skip DisableNodeCaching instance conversion on subsequent attempts #2981
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2979
What changes were proposed in this pull request?
For pipeline export and submit, a
PipelineDefinition
object is initialized multiple times. Any property that is converted to anElyraProperty
, however, only needs to be converted once. An attempt to convert what is already anElyraProperty
will result in unexpected behavior, as seen in #2979. This case is already covered for all properties besidesDisableNodeCaching
here.Because
DisableNodeCaching
currently requires special handling (until #2969 is closed), the sameif
statement linked previously is also added to it's one-offget_single_instance
method.How was this pull request tested?
Tested manually, confirming that
pipelines.kubeflow.org/max_cache_staleness: P0D
appears in the YAML.Developer's Certificate of Origin 1.1