-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable debugger on kernel change #2903
Conversation
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
@lresende this is ready for review :) |
@karlaspuldaro - if have kernelspec debugger set to false with
should i still be seeing the debugger icon and the ability to activate it? |
@akchinSTC Thanks for checking this case, that should disable the button, we might need to update some frontend handlers still. Marking this back to WIP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM but I haven't tested locally yet
Just tried it locally and it's working as expected w/ the xeus kernels and built-in kernel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok for this to go in as is with follow up pr on the issue I mentioned
Follow up issue #2916 |
Fixes #2902 : Changing kernels disables debugging
![change-kernel-fix](https://user-images.githubusercontent.com/25207344/186267457-4535a1a5-eb89-4c72-9a99-f17bc6c5e020.gif)
With this fix, changing the kernel selection to any kernel that supports debugging enables the debug button accordingly.
What changes were proposed in this pull request?
On kernel change, the kernel was shutdown and restarted, although the debugger service and handlers were not updated for some reason.
A simpler solution was to use the
changeKernel
method instead ofshutdown
thenstartKernel
.Other enhancements:
How was this pull request tested?
Developer's Certificate of Origin 1.1