-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Scala editor #2850
Add Scala editor #2850
Conversation
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good, functionally speaking. I'm not qualified to comment on the code changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please also update the related documentation topics:
- getting_started/installation.md
- user_guide/enhanced-script-support.md
- developer_guide/release.md
6431c0f
to
b7b44b3
Compare
b7b44b3
to
d9927c7
Compare
|
||
To run your script locally, select the `Spark/Scala Toree Kernel` option in the dropdown menu, and click the `Run` icon. | ||
|
||
## Ability to execute a Python, R and Scala script as a pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this feature be added to this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is where we add the submit button to other script editors from the pipeline editor package https://github.com/elyra-ai/elyra/blob/main/packages/pipeline-editor/src/index.ts#L336
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe there should be additional places that would require updates because file type verification is performed if one tries to drag and drop a file onto the Pipeline Editor canvas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in scrum, will do the run as pipeline
in another pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you planning to deliver the PR in 3.11? If not, we should undo some of the doc changes to avoid the impression that Scala scripts are supported in pipelines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ive removed the references to scala in this section
Should we treat the Scala code editor as an optionally installable component that is only installed if the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See issues with release script.
Co-authored-by: Patrick Titzler <[email protected]>
I haven't given a lot of thought for this, but we could use a separate pr to do that for the different editors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The required changes to the release script are still missing as mentioned in #2850 (comment). As is, the .whl and .tar.gz files are not published for the new extension.
As it stands right now
Ive update the list of packages to publish via @ptitzler's comment and removed references to scala in run as pipeline section |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
See #2850 (comment) for scope
What changes were proposed in this pull request?
Add Scala editor
How was this pull request tested?
EKS deployment
Developer's Certificate of Origin 1.1