Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scala editor #2850

Merged
merged 8 commits into from
Aug 4, 2022
Merged

Add Scala editor #2850

merged 8 commits into from
Aug 4, 2022

Conversation

lresende
Copy link
Member

@lresende lresende commented Jul 22, 2022

See #2850 (comment) for scope

What changes were proposed in this pull request?

Add Scala editor

How was this pull request tested?

EKS deployment

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@lresende lresende requested a review from karlaspuldaro July 22, 2022 21:47
@elyra-bot
Copy link

elyra-bot bot commented Jul 22, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good, functionally speaking. I'm not qualified to comment on the code changes.

@ptitzler ptitzler added the kind:enhancement New feature or request label Jul 26, 2022
@ptitzler ptitzler added this to the 3.11.0 milestone Jul 26, 2022
Copy link
Member

@ptitzler ptitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also update the related documentation topics:

  • getting_started/installation.md
  • user_guide/enhanced-script-support.md
  • developer_guide/release.md

@akchinSTC akchinSTC requested a review from ajbozarth July 26, 2022 15:34
@lresende lresende force-pushed the apple-scala-editor branch from 6431c0f to b7b44b3 Compare July 26, 2022 22:05
@lresende lresende force-pushed the apple-scala-editor branch from b7b44b3 to d9927c7 Compare July 26, 2022 23:05

To run your script locally, select the `Spark/Scala Toree Kernel` option in the dropdown menu, and click the `Run` icon.

## Ability to execute a Python, R and Scala script as a pipeline
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this feature be added to this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where we add the submit button to other script editors from the pipeline editor package https://github.com/elyra-ai/elyra/blob/main/packages/pipeline-editor/src/index.ts#L336

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there should be additional places that would require updates because file type verification is performed if one tries to drag and drop a file onto the Pipeline Editor canvas.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in scrum, will do the run as pipeline in another pr

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you planning to deliver the PR in 3.11? If not, we should undo some of the doc changes to avoid the impression that Scala scripts are supported in pipelines.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ive removed the references to scala in this section

@ptitzler
Copy link
Member

Should we treat the Scala code editor as an optionally installable component that is only installed if the [all] or [scala-editor] runtime extra was specified? As is, the editor is always installed (just like the R script editor) even though there are probably many users that will never use it.

create-release.py Outdated Show resolved Hide resolved
Copy link
Member

@ptitzler ptitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See issues with release script.

Co-authored-by: Patrick Titzler <[email protected]>
@lresende
Copy link
Member Author

lresende commented Aug 1, 2022

Should we treat the Scala code editor as an optionally installable component that is only installed if the [all] or [scala-editor] runtime extra was specified? As is, the editor is always installed (just like the R script editor) even though there are probably many users that will never use it.

I haven't given a lot of thought for this, but we could use a separate pr to do that for the different editors

@akchinSTC akchinSTC requested a review from ptitzler August 1, 2022 15:36
Copy link
Member

@ptitzler ptitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The required changes to the release script are still missing as mentioned in #2850 (comment). As is, the .whl and .tar.gz files are not published for the new extension.

@akchinSTC
Copy link
Member

akchinSTC commented Aug 3, 2022

As it stands right now

  1. Follow Up PR : Scala editor will be installed alongside the other editors. Not going to make it an optional package until we can get a PR going with the same optional installation support that will encompass the other editors
  2. Follow up PR : Add run-as-pipeline button to scala editor
  3. TODO PR : Not going to create scala-editor conda package yet. Create new staged recipe later.

Ive update the list of packages to publish via @ptitzler's comment and removed references to scala in run as pipeline section

@akchinSTC akchinSTC requested a review from ptitzler August 3, 2022 20:43
Copy link
Member

@ptitzler ptitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akchinSTC akchinSTC mentioned this pull request Aug 4, 2022
5 tasks
@akchinSTC akchinSTC merged commit a402f11 into elyra-ai:main Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants