-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added development environment dockerfile and requirements file #2808
Conversation
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets update the description as well to something well...more descriptive...lol
We want to let people know what they are getting with this new pull request(no need to describe the changes) hint: its what @salonee13 had said during our webex, making things easier for people down the line.
Also how did we test this, its absolutely fine to say we just started up the container with the image and tried running make install
but you should elaborate more.
Updates to documentation:
We also want to update the docs to reflect how people can use this new image. Take a look at docs/source/developer_guide/development-workflow.md
. We probably want to update the requirements section with an OR
and add this image as an option for use.
Also lets add another section that describes how to start the container and map the correct directories to the container e.g. the docker run ....
cmd I gave you.
What changes were proposed in this pull request?
Added two lines checking for node version and yarn version, this would make it easier for people down the line while they are in the process of installing and setting up the elyra environment to check to see if they have the right version of node and yarn installed.
How was this pull request tested?
We would start up the container and run make install, if everything ran smoothly and the command ran with no errors we can assume we had node and yarn properly installed.
Developer's Certificate of Origin 1.1