Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Protocol 13 Support #266

Merged
merged 2 commits into from
Jun 17, 2020
Merged

Protocol 13 Support #266

merged 2 commits into from
Jun 17, 2020

Conversation

fracek
Copy link
Collaborator

@fracek fracek commented Jun 15, 2020

This PR reverts back the change that reverted support for m-strkeys, it also enables generating v1 transactions by default.

I think it's a breaking change since it will generate a different type of transaction by default.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 85.597% when pulling 4090a9b on protocol-13 into f5f875e on master.

Copy link
Collaborator

@Kirbyrawr Kirbyrawr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me so far.

@fracek fracek merged commit 864e749 into master Jun 17, 2020
@fracek fracek mentioned this pull request Jun 17, 2020
@elucidsoft elucidsoft deleted the protocol-13 branch September 2, 2022 12:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants