add withDebuggerName #60
Conversation
| @@ -41,10 +41,11 @@ module Debugger = | |||
| hostname = "remotedev.io" | |||
| port = 443 | |||
| secure = true | |||
| name = "Elmish" | |||
There was a problem hiding this comment.
Magic string "Elmish" used in several places. Here, L141, and L163. Would empty string be a better default?
There was a problem hiding this comment.
Well one is for fallback the other is the default. I am not sure, what is best here though.
| try | ||
| let deflater, inflater = getTransformers<'model>() | ||
| let connection = Debugger.connect<'msg> (Debugger.ViaExtension name) | ||
| withDebuggerUsing deflater inflater connection program |
There was a problem hiding this comment.
All the helper functions call withDebuggerUsing. Maybe the name parameter should be there? To avoid a breaking change, could introduce a new fn withNamedDebuggerUsing with name parameter, move current withDebuggerUsing code there. Then change withDebuggerUsing body to just call withNamedDebuggerUsing.
There was a problem hiding this comment.
This should also reduce the usage of the default name down to 1 place.
There was a problem hiding this comment.
Using says take this connection, at which point, it seems, specifying the name is already too late. Guess we could change the signature of Using to take a function: name -> connection, but that would change the assumptions I originally had when writing this - someone could establish the connection in an arbitrary fashion with regards to options and timing.
I'm onboard with DRY though, there must be a better way to express the default - once.
There was a problem hiding this comment.
Could name be string option? Looks like Thoth's default behavior is to skip null fields. When name is None, it should emit the same json as before this change. Or we could default it to "Elmish" before connecting. Then there's no need for an extra Using fn.
There was a problem hiding this comment.
Or maybe it should be ViaExtension and ViaNamedExtension of name: string. Then no need to worry about default in other fns.
There was a problem hiding this comment.
no need to worry about default in other fns.
I was wondering about that, @OnurGumus is naming supported with remote debugger?
There was a problem hiding this comment.
I think not; but I am not sure.
|
Is this going to go in? |
We have unresolved questions, are you planning to address them? |
|
Can we summarise them? I lost a bit track on what else is required here? |
|
I believe the gist of the commentary so far is that we may need to reorg how defaults are applied so that they don't appear over and over again. |
Fiexes Allow specifying 'name' #58