Make type of get/set propagate to static view model property #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marner2
force-pushed
the
feature/add_map_binding_vm_helper_type
branch
from
90ca052
to
8f868d7
Compare
marner2
force-pushed
the
feature/add_map_binding_vm_helper_type
branch
4 times, most recently
from
7ebaf35
to
c9a4558
Compare
marner2
force-pushed
the
feature/add_map_binding_vm_helper_type
branch
2 times, most recently
from
99c91e6
to
fcb38e5
Compare
marner2
force-pushed
the
feature/add_map_binding_vm_helper_type
branch
2 times, most recently
from
e7ff88e
to
a30d184
Compare
marner2
force-pushed
the
feature/add_map_binding_vm_helper_type
branch
from
a30d184
to
cd861ad
Compare
marner2
force-pushed
the
feature/add_map_binding_vm_helper_type
branch
from
cd861ad
to
94ac988
Compare
marner2
force-pushed
the
feature/add_map_binding_vm_helper_type
branch
from
94ac988
to
139b7eb
Compare
marner2
force-pushed
the
feature/add_map_binding_vm_helper_type
branch
from
02929c4
to
3cc05e9
Compare
marner2
force-pushed
the
feature/add_map_binding_vm_helper_type
branch
from
3cc05e9
to
ecc380b
Compare
marner2
changed the title
LyndonGingerich
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need this in Getter and Setter helpers where you need to keep the type around longer, but box/unbox it before storing/retrieving it from the static type's storage.
Implements full feature that allows for static type of binding specifiers to bubble all the way up to the property.
Merge after #511 and #475(Merged)Should wait until after #522 so that it can include the actual usages (as explained below).EDIT: this may not be necessary, as we may always be able to just unbox things on their way out once #512 is merged in in those getters.Combined with #512