Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize and types in binding vm helpers #468

Conversation

marner2
Copy link
Collaborator

@marner2 marner2 commented May 26, 2022

Waiting on #467

@TysonMN
Copy link
Member

TysonMN commented May 29, 2022

#467 is merged. Can you fix this PR so that it only has one commit?

@marner2 marner2 force-pushed the feature/minimize_and_types_in_BindingVmHelpers branch from 949f045 to 1bbccd4 Compare May 31, 2022 18:29
@marner2
Copy link
Collaborator Author

marner2 commented May 31, 2022

@TysonMN should be done

@TysonMN
Copy link
Member

TysonMN commented Jun 2, 2022

I tried to merge this using FastHub but got a 405 HTTP error.

Is there maybe a merge conflict?

@marner2 marner2 force-pushed the feature/minimize_and_types_in_BindingVmHelpers branch from 1bbccd4 to 9d66a0c Compare June 2, 2022 19:20
@marner2
Copy link
Collaborator Author

marner2 commented Jun 2, 2022

@TysonMN no I had to click update branch

@marner2
Copy link
Collaborator Author

marner2 commented Jun 2, 2022

Do you have the ability to click "Update Branch" on my branches?

@TysonMN TysonMN merged commit f061b6e into elmish:master Jun 4, 2022
@marner2 marner2 deleted the feature/minimize_and_types_in_BindingVmHelpers branch June 4, 2022 16:35
@marner2 marner2 mentioned this pull request Jun 27, 2022
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants