Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split binding helpers not related to ViewModel.fs after it #450

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

marner2
Copy link
Collaborator

@marner2 marner2 commented Mar 13, 2022

Moves all of the bindings helpers into a new file that has visibility into the ViewModel.fs file. The reason for this is twofold, one to split away everything that ViewModel.fs isn't dependent on, and another to allow future expansion of Bindings to have access to ViewModel.fs when we change things up.

#449

@TysonMN
Copy link
Member

TysonMN commented Mar 13, 2022

one to split away everything that ViewModel.fs isn't dependent on

I am satisfied with this first reason.

How about we call these files BindingsInternal.fs and BindingsPublic.fs? That accurately describes the difference between these files, right? If so, do you think will that continue to be an accurate description as you make all your desired changes?

@marner2
Copy link
Collaborator Author

marner2 commented Mar 13, 2022

Actually if I go Bindings.fs and BindingsInternal.fs it might shrink the diff significantly, hang on...

@marner2
Copy link
Collaborator Author

marner2 commented Mar 14, 2022

@TysonMN please review. There are no actual code changes, only rearrangements.

@TysonMN TysonMN merged commit c281321 into elmish:master Mar 15, 2022
@marner2 marner2 deleted the feature/split_bindings branch March 15, 2022 03:53
@marner2 marner2 mentioned this pull request Jun 27, 2022
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants