This repository has been archived by the owner on Aug 23, 2018. It is now read-only.
Make Description.repo a Maybe instead of filling in a junk value #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evancz
pushed a commit
that referenced
this pull request
Oct 11, 2015
We can do a more serious fix with elm-lang/elm-make#59. This fix supersedes #152 for now.
|
I want to go with a dumber fix for now. Maybe it's less good, but it is very low risk. We know everything works fine with the current set up. I think elm-lang/elm-make#59 will be the right way to go, so I want to do more serious changes when it's time to do that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@evancz maybe you already have another plan in mind or in progress, but here's my thought on fixing the "Upper case characters are not allowed in package names" error with
https://github.com/USER/PROJECT.gitin 0.16A similar change would have to be made for elm-compiler. (and any of the other tools that might parse elm-package.json)